feat(v2/column): support columnWidthRatio and marginRatio #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
hustcc
reviewed
Jul 29, 2020
|
|
||
| if (!isNil(columnWidthRatio)) { | ||
| chart.theme({ | ||
| columnWidthRatio, |
There was a problem hiding this comment.
这个是按照比率的吧，后面如要要支持像素怎么办~还有上面的 marginRatio 也是一样的。
hustcc
approved these changes
Jul 29, 2020
pr-triage
bot
added
PR: merged
PR: reviewed-changes-requested
and removed
PR: reviewed-changes-requested
PR: merged
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.